Skip to content

[PWGEM/Dilepton] add a v1 task#16899

Merged
dsekihat merged 7 commits into
AliceO2Group:masterfrom
dsekihat:master
Jul 2, 2026
Merged

[PWGEM/Dilepton] add a v1 task#16899
dsekihat merged 7 commits into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat

@dsekihat dsekihat commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton] add a v1 task

@github-actions github-actions Bot added the pwgem label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 41 errors, ⚠️ 70 warnings, 🔕 0 disabled

@dsekihat dsekihat enabled auto-merge (squash) July 2, 2026 09:34
alibuild
alibuild previously approved these changes Jul 2, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat disabled auto-merge July 2, 2026 09:34
@alibuild

alibuild commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 7b7cdf6 at 2026-07-02 11:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/Dilepton/Tasks/dimuonV1.cxx:373:21: error: unused variable 'nlspp' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/Dilepton/Tasks/dimuonV1.cxx:373:32: error: unused variable 'nlsmm' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@dsekihat
Remove unused variables in dimuonV1.cxx
7616d19 
Commented out unused variables 'nlspp' and 'nlsmm'.
@alibuild alibuild mentioned this pull request Jul 2, 2026
Merged
@dsekihat
Merge pull request #107 from alibuild/alibot-cleanup-16899
d64aece 
Please consider the following formatting changes to AliceO2Group#16899
@dsekihat dsekihat enabled auto-merge (squash) July 2, 2026 09:46
alibuild
alibuild previously approved these changes Jul 2, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat disabled auto-merge July 2, 2026 10:10
@alibuild alibuild mentioned this pull request Jul 2, 2026
Merged
@alibuild

alibuild commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d64aece at 2026-07-02 12:13:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 19 errors and 0 warnings.'
Found 19 errors and 0 warnings.
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/c0a9f37a6318e4dd022bd5e879f35ff75676311e/O2Physics-code-check/errors.txt
PWGEM/Dilepton/Tasks/dimuonV1.cxx:21:1: error: included header EMTrack.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:22:1: error: included header EMTrackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:25:1: error: included header PairUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:32:1: error: included header LHCConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:33:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:48:1: error: included header Utils.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:52:1: error: included header TH1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:53:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:54:1: error: included header TString.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:56:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:60:1: error: included header chrono is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:62:1: error: included header cstddef is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:65:1: error: included header random is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:69:1: error: included header unordered_map is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:73:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:180:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:205:3: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:373:11: error: variable 'nuls' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGEM/Dilepton/Tasks/dimuonV1.cxx:487:129: error: no header providing "o2::aod::fwdtrack::ForwardTrackTypeEnum" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 19 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat
Merge pull request #108 from alibuild/alibot-cleanup-16899
ec2c496 
[PWGEM] Please consider the following formatting changes to AliceO2Group#16899
@dsekihat dsekihat enabled auto-merge (squash) July 2, 2026 10:16
alibuild
alibuild approved these changes Jul 2, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild

alibuild commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ec2c496 at 2026-07-02 13:14:

++ set -euo pipefail
++ [[ -d /sw/slc9_x86-64/Clang/v20.1.7-20 ]]
+++ realpath /sw/BUILD/0e3aa6712190c525275aed364e2f945a014f59b5/O2Physics-code-check/../../O2Physics-latest/O2Physics
++ O2PHYSICS_BUILDDIR=/sw/BUILD/2e9b5ce56bc1c19c5989bacfb4a9ca72071eb2d0/O2Physics
++ cp /sw/BUILD/2e9b5ce56bc1c19c5989bacfb4a9ca72071eb2d0/O2Physics/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2PHYSICS_SRC=/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
++ pushd /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
/sw/SPECS/slc9_x86-64/O2Physics-code-check/1.0-local5/O2Physics-code-check.sh: line 16: pushd: /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0: No such file or directory

Full log here.

@dsekihat dsekihat merged commit 4442132 into AliceO2Group:master Jul 2, 2026
13 of 16 checks passed
mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jul 9, 2026
@dsekihat @alibuild @mcoquet642
[PWGEM/Dilepton] add a v1 task (AliceO2Group#16899)
52c3312 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

Assignees

No one assigned

Labels

pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsekihat @alibuild